[vote] Lightread

[Bhavani Shankar R]

On Sat, Aug 4, 2012 at 12:17 PM, Bhavani Shankar R <bhavi at ubuntu.com> wrote:
> On Thu, Aug 2, 2012 at 5:00 PM, Jono Cooper <jono at jonocooper.com> wrote:
>> Yep, issues are fixed.
>>
>> Cheers
>>
>
> Just pulled in the latest branch
>
> App working for me here now wrt sync and refresh.
>
> But havent had a look at the packaging yet
>
> So m reserving my vote for now
>
> Regards,
>

Packaging looks generally good except:

lightread/data/media/app/config.rb doesnt specify a license (although
in d/copyright its mentioned that all files are in bsd 3)

Lintian reports warning wrt d/copyright

W: lightread source: syntax-error-in-dep5-copyright line 8: Duplicate
field copyright.

the runtime.d/ directory was found to be empty

drwxr-xr-x root/root         0 2012-08-05 23:08 ./usr/share/python/runtime.d/

(It just stores *.rtupdate file(s) and can be removed I guess)

stopping review here.

As a side note: ran the app clicked on settings and found no way there
to close the settings window on my system. Am I missing something
here?

I would like to still keep my +0 here

Regards,

-

-- 
Bhavani Shankar
Ubuntu Developer       |  www.ubuntu.com
https://launchpad.net/~bhavi