[Vote] Fogger

[Owas Lone]

On Fri, Aug 3, 2012 at 12:17 AM, Allison Randal <allison at ubuntu.com> wrote:
> On 08/01/2012 10:21 PM, Bhavani Shankar R wrote:
>> Just went through the package. Looks fine here except few nitpicks in
>> d/control as shown by lintian below
>>
>> E: fogger: description-starts-with-package-name
>> I: fogger: description-synopsis-might-not-be-phrased-properly
>> W: fogger: description-too-long
>> I: fogger: capitalization-error-in-description linux Linux
>
> Fixed these.
>
>> P: fogger: no-homepage-field
>
> Left this.
>
>> and
>>
>> W: fogger: executable-not-elf-or-script
>> opt/extras.ubuntu.com/fogger/share/fogger/templates/fogapp.desktop.tmpl
>>
>> Looking into the code, seems like a desktop file template and can be
>> bypassed I guess
>
> Also left this, because I think it's being used to generate the desktop
> files for the webapp wrappers it creates.
>
>> +1 from me for this now (few nitpicks present but that is minor I believe)
>>
>> Adding bzr-builddeb.conf I can build the package using bzr bd now.
>
> Added this.
>
> I'm trying to publish to extras PPA (and push my changes to a lp bzr
> branch), but I keep getting a connection timeout. :(
>
> ======
> Uploading fogger_0.2.3-extras12.04.1.tar.gz: 18k/753k[Errno 110]
> Connection timed out
> ======
>
> If anyone else wants to try uploading with the attached patch applied to
> Owais's latest version (which integrates all changes from reviewers),
> please do.
>
> lp:~loneowais/fogger/arb-review
>
> Allison

Thanks Allison,

I've merged the patch.

-- 
Owais Lone
hello at owaislone.org
http://www.owaislone.org