[Vote] Fogger

[Bhavani Shankar R]

Just went through the package. Looks fine here except few nitpicks in
d/control as shown by lintian below

E: fogger: description-starts-with-package-name
I: fogger: description-synopsis-might-not-be-phrased-properly
W: fogger: description-too-long
I: fogger: capitalization-error-in-description linux Linux
P: fogger: no-homepage-field

and

W: fogger: executable-not-elf-or-script
opt/extras.ubuntu.com/fogger/share/fogger/templates/fogapp.desktop.tmpl

Looking into the code, seems like a desktop file template and can be
bypassed I guess

+1 from me for this now (few nitpicks present but that is minor I believe)

Adding bzr-builddeb.conf I can build the package using bzr bd now.

Regards

On Thu, Aug 2, 2012 at 6:13 AM, Allison Randal <allison at ubuntu.com> wrote:
> Yeah, that's a known problem with our current package version
> requirements. You can also add a file debian/bzr-builddeb.conf
>
> [BUILDDEB]
> native = True
>
> On 08/01/2012 05:13 PM, Michael Hall wrote:
>> I fixed the control and copyright files, my branch is:
>>
>> https://code.launchpad.net/~mhall119/fogger/fixes-for-stephane/
>>
>> Note that because Allison added "-0extras12.04.1" to the version number
>> in the changelog file, "bzr bd" expects there to be an upstream
>> .orig.tar.gz available and fails when one doesn't exist.  To make it
>> build from the source in the branch, you will need to run "bzr bd
>> --split", which will first create the .orig.tar.gz file.
>>
>> Michael Hall
>> mhall119 at ubuntu.com
>>
>> On 08/01/2012 05:15 PM, Stéphane Graber wrote:
>>> On 07/27/2012 02:35 PM, Owas Lone wrote:
>>>> On Fri, Jul 27, 2012 at 11:26 PM, Allison Randal <allison at ubuntu.com> wrote:
>>>>> On 07/21/2012 11:25 AM, Owas Lone wrote:
>>>>>> Updated the branch lp:~loneowais/fogger/arb-review to the latest from
>>>>>> lp:~loneowais/fogger/quickly_trunk which is used for PPA builds
>>>>>> (ppa:loneowais/fogger)
>>>>>
>>>>> Confirmed that this latest update includes the fixes stgraber requested.
>>>>> I also did a more detailed code review of the Javascript bridge, and
>>>>> approve. (I've written a couple of these now, they're safe when input is
>>>>> properly filtered.)
>>>>>
>>>>> A couple of quick fixes:
>>>>>
>>>>> - Update the fields of debian/copyright to the current format (see
>>>>> https://wiki.ubuntu.com/AppReviewBoard/Submissions/QuicklyTips)
>>>>>
>>>>> - Add "-extras12.04.1" to the version in debian/changelog.
>>>>>
>>>>> +1, conditioned on these final 2 changes
>>>>>
>>>>> Allison
>>>>
>>>> Hi Allison,
>>>>
>>>> I've pushed the requested fixes to lp:~loneowais/fogger/arb-review
>>>>
>>>> Thank you!
>>>
>>>  - Package doesn't build when doing "bzr bd"
>>>  - The GPL-3 is defined twice in debian/copyright (the one at the bottom
>>> is enough)
>>>  - debian/control build-depends on cdbs but you aren't using it
>>>
>>> The package not being buildable prevents me from finishing the review,
>>> so sticking to my -1 for now.
>>>
>>>
>>>
>>>
>>
>
> --
> App-review-board mailing list
> App-review-board at lists.ubuntu.com
> Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/app-review-board



-- 
Bhavani Shankar
Ubuntu Developer       |  www.ubuntu.com
https://launchpad.net/~bhavi