Mundus submitted 3 weeks ago

[Sebastian Kulesz]

On Sun, Apr 1, 2012 at 2:48 PM, Allison Randal <allison at lohutok.net> wrote:

> Hi Sebastian,
>
> On 03/31/2012 08:59 PM, Sebastian Kulesz wrote:
> > Hi! I submitted my application 3 weeks ago. I would like to know
> > what's the status of the review, I don't really know what's the
> > average time per app.
> >
> > Is there an application queue to get an estimated completion time?
> >
> > Thanks a lot!
>
> You can see the full queue of current apps at:
>
> https://myapps.developer.ubuntu.com/dev/arb/
>
> Let's see, it looks like you've done the debian packaging, that's good.
> One thing that needs to be changed for ARB apps is to install your app
> in /opt/extras.ubuntu.com/mundus. There are two special variables in
> Makefiles that can help make this easy: DESTDIR and PREFIX.
>
> DESTDIR is the way debian sets the special install location for building
> packages. Right now you've got this working with a variable named
> PREFIX, and a patch that sets:
>
> PREFIX ?= debian/mundus
>
> But, if you change that variable name to DESTDIR, debian/rules will set
> it for you automatically. (See
> http://www.gnu.org/prep/standards/html_node/DESTDIR.html for more
> details.)
>
>
> PREFIX should be the system install path, like /usr, or /usr/local, or
> /opt/extras.ubuntu.com/mundus. I suggest starting your Makefile with
> something like:
>
> PREFIX ?= /usr
> bindir = $(PREFIX)/bin
> libdir = $(PREFIX)/lib
> datadir = $(PREFIX)/share
>
> And then in the install and uninstall targets, replace literal paths like:
>
>        install -d -m 755 $(PREFIX)/usr/share/pixmaps
>
> With a line that uses the defined variables:
>
>        install -d -m 755 $(DESTDIR)$(datadir)/pixmaps
>
> That way, the debian/rules file can just set the install path once by
> setting PREFIX:
>
> override_dh_auto_install:
>        dh_auto_install -- PREFIX=/opt/extras.ubuntu.com/mundus
>
> The one exception is the mundus.desktop file, which you should still
> install in $(DESTDIR)/usr/share/applications.
>
>
> There are several other ways to change the install paths, but this way
> is the easiest for a simple Makefile. And, it will let you maintain your
> regular package and ARB package without patching the Makefile. Let us
> know if you have any questions.
>
> Thanks,
> Allison
>

Hi! I have updated the makefile. You can check the new version at the
bazaar repository of the project at launchpad. I will soon release a new
version with this fix included.

Thanks!
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/app-review-board/attachments/20120407/acf9fe98/attachment.html>