ACK: [PATCH 3/3] uefidump: add dumping for the SD device path

[Alex Hung]

On 2015-11-20 04:40 PM, Ivan Hu wrote:
> Add dumping with uefi spec. 2.5 for new messaging device path, SD device path
>
> Signed-off-by: Ivan Hu <ivan.hu at canonical.com>
> ---
>   src/uefi/uefidump/uefidump.c | 6 ++++++
>   1 file changed, 6 insertions(+)
>
> diff --git a/src/uefi/uefidump/uefidump.c b/src/uefi/uefidump/uefidump.c
> index c56082d..52e6331 100644
> --- a/src/uefi/uefidump/uefidump.c
> +++ b/src/uefi/uefidump/uefidump.c
> @@ -505,6 +505,12 @@ static char *uefidump_build_dev_path(char *path, fwts_uefi_dev_path *dev_path, c
>   					u->target_id, u->lun);
>   			}
>   			break;
> +		case FWTS_UEFI_SD_DEVICE_PATH_SUBTYPE:
> +			if (dev_path_len >= sizeof(fwts_uefi_sd_dev_path)) {
> +				fwts_uefi_sd_dev_path *s = (fwts_uefi_sd_dev_path *)dev_path;
> +				path = uefidump_vprintf(path, "\\SD(0x%" PRIx8 ")", s->slot_number);
> +			}
> +			break;
>   		default:
>   			path = uefidump_vprintf(path, "\\Unknown-MESSAGING-DEV-PATH(0x%" PRIx8 ")", dev_path->subtype);
>   			break;
>

Acked-by: Alex Hung <alex.hung at canonical.com>