[PATCH] acpi: acpitables: remove irrelevant test case (LP: #1287891)

[Colin King]

From: Colin Ian King <colin.king at canonical.com>

Although the ACPI specification in section 5.2.9 states that
the 32 bit and the 64 bit firmware controls should not be both
defined at the same time, the reality is that it is on a lot of
firmware and the the kernel uses the 64 bit version if both are
defined. So just remove this test as it causes more harm than
good.

Signed-off-by: Colin Ian King <colin.king at canonical.com>
---
 src/acpi/acpitables/acpitables.c | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/src/acpi/acpitables/acpitables.c b/src/acpi/acpitables/acpitables.c
index 51948bd..6878734 100644
--- a/src/acpi/acpitables/acpitables.c
+++ b/src/acpi/acpitables/acpitables.c
@@ -89,16 +89,6 @@ static void acpi_table_check_fadt(fwts_framework *fw, fwts_acpi_table_info *tabl
 	} else {
 		if (table->length >= 140) {
 			if (fadt->x_firmware_ctrl != 0) {
-				fwts_failed(fw, LOG_LEVEL_MEDIUM, "FADT32And64BothDefined", "FADT 32 bit FIRMWARE_CONTROL is non-zero, and X_FIRMWARE_CONTROL is also non-zero. "
-						"Section 5.2.9 of the ACPI specification states that if the FIRMWARE_CONTROL is non-zero "
-						"then X_FIRMWARE_CONTROL must be set to zero.");
-				fwts_advice(fw, "The FADT FIRMWARE_CTRL is a 32 bit pointer that points to the physical memory address "
-						"of the Firmware ACPI Control Structure (FACS).  There is also an extended 64 bit version "
-						"of this, the X_FIRMWARE_CTRL pointer that also can point to the FACS.  Section 5.2.9 of "
-						"the ACPI specification states that if the X_FIRMWARE_CTRL field contains a non zero value "
-						"then the FIRMWARE_CTRL field *must* be zero.  This error is also detected by the Linux kernel. "
-						"If FIRMWARE_CTRL and X_FIRMWARE_CTRL are defined, then the kernel just uses the 64 bit version of "
-						"the pointer.");
 				if (((uint64_t)fadt->firmware_control != fadt->x_firmware_ctrl)) {
 					fwts_failed(fw, LOG_LEVEL_MEDIUM, "FwCtrl32and64Differ",
 						"FIRMWARE_CONTROL is 0x%" PRIx32 " and differs "
-- 
1.9.0