[PATCH] Force to use automake1.11 to prevent FTBFS in Trusy (LP: #1250340)

[Colin Ian King]

On 12/11/13 11:13, Keng-Yu Lin wrote:
> Yes, this is expected.
> 
> This patch only works if it starts from `debian/rules`.
> 
> You can specify the environment vars as below with autoreconf, it should work:
> 
>   $ AUTOMAKE=automake-1.11 ACLOCAL=aclocal-1.11 autoreconf -ivf
> 
> (have to install automake1.11 deb first.)
> 
> 
Ah, that breaks my normal development way of working where I do:

git clone git://kernel.ubuntu.com/hwe/fwts
autoreconf -ivf
./configure
make

Is there a way of defaulting these environment vars so we don't need to
explicitly set these when doing a non-debian build?

> 
> On Tue, Nov 12, 2013 at 6:45 PM, Colin Ian King
> <colin.king at canonical.com> wrote:
>> On 12/11/13 09:45, Keng-Yu Lin wrote:
>>> Signed-off-by: Keng-Yu Lin <kengyu at canonical.com>
>>> ---
>>>  debian/control | 2 +-
>>>  debian/rules   | 2 ++
>>>  2 files changed, 3 insertions(+), 1 deletion(-)
>>>
>>> the default automake in Ubuntu Trusty is 1.14
>>>
>>> diff --git a/debian/control b/debian/control
>>> index 368e578..5bec45c 100644
>>> --- a/debian/control
>>> +++ b/debian/control
>>> @@ -4,7 +4,7 @@ Priority: optional
>>>  Maintainer: Firmware Testing Team <fwts-devel at lists.ubuntu.com>
>>>  Uploaders: Colin King <colin.king at ubuntu.com>, Keng-Yu Lin <kengyu at ubuntu.com>, Alex Hung <alex.hung at canonical.com>, Chris Van Hoof <vanhoof at canonical.com>, Ivan Hu <ivan.hu at canonical.com>
>>>  Standards-Version: 3.9.3
>>> -Build-Depends: debhelper (>= 7.0.50~), autoconf, automake, libtool, libpcre3-dev (>= 7.8), libjson0-dev (>= 0.9), flex, bison, hardening-wrapper, dh-autoreconf, dkms
>>> +Build-Depends: debhelper (>= 7.0.50~), autoconf, automake1.11, libtool, libpcre3-dev (>= 7.8), libjson0-dev (>= 0.9), flex, bison, hardening-wrapper, dh-autoreconf, dkms
>>>
>>>  Package: fwts
>>>  Architecture: any
>>> diff --git a/debian/rules b/debian/rules
>>> index 503c19d..cd95821 100755
>>> --- a/debian/rules
>>> +++ b/debian/rules
>>> @@ -1,6 +1,8 @@
>>>  #!/usr/bin/make -f
>>>
>>>  export DEB_BUILD_HARDENING=1
>>> +export AUTOMAKE=automake-1.11
>>> +export ACLOCAL=aclocal-1.11
>>>
>>>  DEBVERS := $(shell dpkg-parsechangelog | grep ^Version: | cut -d' ' -f2 \
>>>               | cut -d- -f1)
>>>
>>
>> Keng-Yu, I applied this and ran autoreconf -ivf in a clean trusty build
>> environment and I'm getting:
>>
>> autoreconf: running: automake --add-missing --copy --force-missing
>> configure.ac:3: installing './ar-lib'
>> configure.ac:3: installing './compile'
>> configure.ac:4: installing './config.guess'
>> configure.ac:4: installing './config.sub'
>> configure.ac:2: installing './install-sh'
>> configure.ac:2: installing './missing'
>> automake: warnings are treated as errors
>> src/Makefile.am:21: warning: source file 'acpi/ac_adapter/ac_adapter.c'
>> is in a subdirectory,
>> src/Makefile.am:21: but option 'subdir-objects' is disabled
>> automake: warning: possible forward-incompatibility.
>> automake: At least a source file is in a subdirectory, but the
>> 'subdir-objects'
>> automake: automake option hasn't been enabled.  For now, the
>> corresponding output
>> automake: object file(s) will be placed in the top-level directory.
>> However,
>> automake: this behaviour will change in future Automake versions: they will
>> automake: unconditionally cause object files to be placed in the same
>> subdirectory
>> automake: of the corresponding sources.
>> automake: You are advised to start using 'subdir-objects' option
>> throughout your
>> automake: project, to avoid future incompatibilities.
>> src/Makefile.am:21: warning: source file 'acpi/acpidump/acpidump.c' is
>> in a subdirectory,
>> src/Makefile.am:21: but option 'subdir-objects' is disabled
>> src/Makefile.am:21: warning: source file 'acpi/acpiinfo/acpiinfo.c' is
>> in a subdirectory,
>> src/Makefile.am:21: but option 'subdir-objects' is disabled
>> src/Makefile.am:21: warning: source file 'acpi/acpitables/acpitables.c'
>> is in a subdirectory,
>> src/Makefile.am:21: but option 'subdir-objects' is disabled
>> src/Makefile.am:21: warning: source file
>> 'acpi/apicinstance/apicinstance.c' is in a subdirectory,
>>
>>
>> Any ideas?
>>
>> --
>> fwts-devel mailing list
>> fwts-devel at lists.ubuntu.com
>> Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/fwts-devel