[PATCH] uefi: uefidump: fix missing break in switch statement

Colin King colin.king at canonical.com
Mon May 6 23:49:23 UTC 2013


From: Colin Ian King <colin.king at canonical.com>

Coverity CID #997290, Missing break in switch

We are missing a break causing and unintentional fall-through to
an Unknown-ACPI-DEV-PATH default.

Signed-off-by: Colin Ian King <colin.king at canonical.com>
---
 src/uefi/uefidump/uefidump.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/uefi/uefidump/uefidump.c b/src/uefi/uefidump/uefidump.c
index b115a62..771f904 100644
--- a/src/uefi/uefidump/uefidump.c
+++ b/src/uefi/uefidump/uefidump.c
@@ -168,6 +168,7 @@ static char *uefidump_build_dev_path(char *path, fwts_uefi_dev_path *dev_path)
 				else
 					path = uefidump_vprintf(path, "%s,", hidstr);
 			}
+			break;
 		default:
 			path = uefidump_vprintf(path, "\\Unknown-ACPI-DEV-PATH(0x%" PRIx8 ")", dev_path->subtype);
 			break;
-- 
1.8.1.2




More information about the fwts-devel mailing list